[Crash] Fix crash in CheckTradeskillLoreConflict (#3009)

This commit is contained in:
Aeadoin 2023-02-27 20:24:05 -05:00 committed by GitHub
parent 3296287d70
commit 93c79817cd
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23

View File

@ -1888,6 +1888,8 @@ bool Client::CheckTradeskillLoreConflict(int32 recipe_id)
if (fi_is_valid) { if (fi_is_valid) {
auto tre_update_item_inst = database.GetItem(tre_update_item.item_id); auto tre_update_item_inst = database.GetItem(tre_update_item.item_id);
bool ei_is_valid = tre_update_item_inst && tre_update_item_inst->LoreGroup != 0; bool ei_is_valid = tre_update_item_inst && tre_update_item_inst->LoreGroup != 0;
if (ei_is_valid) {
bool unique_lore_group_match = tre_inst->LoreGroup > 0 && tre_inst->LoreGroup == tre_update_item_inst->LoreGroup; bool unique_lore_group_match = tre_inst->LoreGroup > 0 && tre_inst->LoreGroup == tre_update_item_inst->LoreGroup;
bool component_count_is_valid = tre_update_item.componentcount == 0 && tre.componentcount > 0; bool component_count_is_valid = tre_update_item.componentcount == 0 && tre.componentcount > 0;
@ -1900,6 +1902,7 @@ bool Client::CheckTradeskillLoreConflict(int32 recipe_id)
} }
} }
} }
}
if (tre_inst) { if (tre_inst) {
if (tre_inst->LoreGroup == 0 || tre.componentcount > 0 || tre.iscontainer) { if (tre_inst->LoreGroup == 0 || tre.componentcount > 0 || tre.iscontainer) {