From 93b3f97f24ccaceccbed98d5a73b428ddc2ba6e0 Mon Sep 17 00:00:00 2001
From: Alex King <89047260+Kinglykrab@users.noreply.github.com>
Date: Wed, 5 Apr 2023 12:14:14 -0400
Subject: [PATCH] [Cleanup] Cleanup discord.cpp and discord_manager.cpp (#3205)

# Notes
- Unused variables in `discord.cpp`.
- Use `.clear()` instead of setting to `""` in `discord_manager.cpp`.
---
 common/discord/discord.cpp         | 6 ------
 common/discord/discord_manager.cpp | 4 ++--
 2 files changed, 2 insertions(+), 8 deletions(-)

diff --git a/common/discord/discord.cpp b/common/discord/discord.cpp
index e06311035..ec75e0560 100644
--- a/common/discord/discord.cpp
+++ b/common/discord/discord.cpp
@@ -27,9 +27,6 @@ void Discord::SendWebhookMessage(const std::string &message, const std::string &
 	cli.set_connection_timeout(0, 15000000); // 15 sec
 	cli.set_read_timeout(15, 0); // 15 seconds
 	cli.set_write_timeout(15, 0); // 15 seconds
-	httplib::Headers headers = {
-		{"Content-Type", "application/json"}
-	};
 
 	// payload
 	Json::Value p;
@@ -96,9 +93,6 @@ void Discord::SendPlayerEventMessage(
 	cli.set_connection_timeout(0, 15000000); // 15 sec
 	cli.set_read_timeout(15, 0); // 15 seconds
 	cli.set_write_timeout(15, 0); // 15 seconds
-	httplib::Headers headers = {
-		{"Content-Type", "application/json"}
-	};
 
 	std::string payload = PlayerEventLogs::GetDiscordPayloadFromEvent(e);
 	if (payload.empty()) {
diff --git a/common/discord/discord_manager.cpp b/common/discord/discord_manager.cpp
index e8691e763..a425d4c34 100644
--- a/common/discord/discord_manager.cpp
+++ b/common/discord/discord_manager.cpp
@@ -37,7 +37,7 @@ void DiscordManager::ProcessMessageQueue()
 					message,
 					webhook.webhook_url
 				);
-				message = "";
+				message.clear();
 			}
 
 			message += m;
@@ -51,7 +51,7 @@ void DiscordManager::ProcessMessageQueue()
 						webhook.webhook_url
 					);
 				}
-				message = "";
+				message.clear();
 			}
 		}
 		// final flush