pa/eqemu-server
2
0
Fork 0
mirror of https://github.com/EQEmu/Server.git synced 2025-12-15 12:31:31 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

[Cleanup] Remove always true statements in task_client_state.cpp (#3292)

Browse Source 
# Notes
- `!tasks_enabled.empty()` is always true.
- `tasks_disabled.size()` is always true.
This commit is contained in:
Alex King 2023-04-14 19:38:35 -04:00 committed by GitHub
parent 3f4334985b
commit 9215ba7a8a
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 2 additions and 18 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

20
zone/task_client_state.cpp
View File

@ -169,13 +169,7 @@ void ClientTaskState::EnableTask(int character_id, int task_count, int *task_lis
query_stream << (i ? ", " : "") << StringFormat("(%i, %i)", character_id, tasks_enabled[i]); query_stream << (i ? ", " : "") << StringFormat("(%i, %i)", character_id, tasks_enabled[i]);
} }
std::string query = query_stream.str(); database.QueryDatabase(query_stream.str());
if (!tasks_enabled.empty()) {
database.QueryDatabase(query);
}
else {
LogTasks("Called for character_id [{}] but, no tasks exist", character_id);
}
} }
void ClientTaskState::DisableTask(int character_id, int task_count, int *task_list) void ClientTaskState::DisableTask(int character_id, int task_count, int *task_list)
@ -228,17 +222,7 @@ void ClientTaskState::DisableTask(int character_id, int task_count, int *task_li
queryStream << ")"; queryStream << ")";
std::string query = queryStream.str(); database.QueryDatabase(queryStream.str());
if (tasks_disabled.size()) {
database.QueryDatabase(query);
}
else {
LogTasks(
"DisableTask called for character_id [{}] ... but, no tasks exist",
character_id
);
}
} }
bool ClientTaskState::IsTaskEnabled(int task_id) bool ClientTaskState::IsTaskEnabled(int task_id)