From 8df7bcc2c8df71c9867e3248e096128ddb7bbc94 Mon Sep 17 00:00:00 2001
From: "Michael Cook (mackal)" <mcook@mackal.net>
Date: Thu, 8 Aug 2019 14:26:08 -0400
Subject: [PATCH] Fix double free in queryserv

---
 queryserv/database.cpp | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/queryserv/database.cpp b/queryserv/database.cpp
index fcda884e4..1e06f229e 100644
--- a/queryserv/database.cpp
+++ b/queryserv/database.cpp
@@ -379,6 +379,7 @@ void Database::LogMerchantTransaction(QSMerchantLogTransaction_Struct* QS, uint3
 
 }
 
+// this function does not delete the ServerPacket, so it must be handled at call site
 void Database::GeneralQueryReceive(ServerPacket *pack) {
 	/*
 		These are general queries passed from anywhere in zone instead of packing structures and breaking them down again and again
@@ -393,7 +394,6 @@ void Database::GeneralQueryReceive(ServerPacket *pack) {
 		Log(Logs::Detail, Logs::QS_Server, "%s", query.c_str());
 	}
 
-	safe_delete(pack);
 	safe_delete_array(queryBuffer);
 }