From 8afbc585da1bf5dd5638ca5118e9198c1a09b7ed Mon Sep 17 00:00:00 2001
From: Alex King <89047260+Kinglykrab@users.noreply.github.com>
Date: Wed, 5 Apr 2023 11:22:23 -0400
Subject: [PATCH] [Cleanup] Remove bool return from GetSharedPlatinum() (#3191)

# Notes
- This was returning `false` and implicitly converting it to an integer.
---
 common/shareddb.cpp | 16 ++++++----------
 1 file changed, 6 insertions(+), 10 deletions(-)

diff --git a/common/shareddb.cpp b/common/shareddb.cpp
index e6afeb2f4..d695bb46d 100644
--- a/common/shareddb.cpp
+++ b/common/shareddb.cpp
@@ -425,17 +425,13 @@ bool SharedDatabase::DeleteSharedBankSlot(uint32 char_id, int16 slot_id) {
 
 int32 SharedDatabase::GetSharedPlatinum(uint32 account_id)
 {
-	const std::string query = StringFormat("SELECT sharedplat FROM account WHERE id = '%i'", account_id);
-    auto results = QueryDatabase(query);
-    if (!results.Success()) {
-		return false;
-    }
-
-    if (results.RowCount() != 1)
-        return 0;
-
-	auto& row = results.begin();
+	const auto query   = fmt::format("SELECT sharedplat FROM account WHERE id = {}", account_id);
+	auto       results = QueryDatabase(query);
+	if (!results.Success() || !results.RowCount()) {
+		return 0;
+	}
 
+	auto row = results.begin();
 	return Strings::ToInt(row[0]);
 }