From 15c15f0687f34fd7279d7a295b08b9786fd52693 Mon Sep 17 00:00:00 2001 From: "copilot-swe-agent[bot]" <198982749+Copilot@users.noreply.github.com> Date: Sun, 8 Mar 2026 15:46:48 +0000 Subject: [PATCH 2/3] Fix false error log: use < instead of != when checking ReplaceMany result in SaveBuffs Co-authored-by: Valorith <76063792+Valorith@users.noreply.github.com> --- zone/zonedb.cpp | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/zone/zonedb.cpp b/zone/zonedb.cpp index 91c466d20..6a1607086 100644 --- a/zone/zonedb.cpp +++ b/zone/zonedb.cpp @@ -2935,9 +2935,9 @@ void ZoneDatabase::SaveBuffs(Client *client) if (!v.empty()) { const auto saved_count = CharacterBuffsRepository::ReplaceMany(database, v); - if (saved_count != static_cast(v.size())) { + if (saved_count < static_cast(v.size())) { LogError( - "Failed to save all buffs for character [{}] [{}]. Expected [{}] rows, saved [{}]. Verify the `character_buffs` schema is up to date.", + "Failed to save all buffs for character [{}] [{}]. Expected at least [{}] rows saved, got [{}]. Verify the `character_buffs` schema is up to date.", client->GetCleanName(), client->CharacterID(), v.size(), From 43d3a631a0860ecb64834ac88c0e5b627cbe3096 Mon Sep 17 00:00:00 2001 From: "copilot-swe-agent[bot]" <198982749+Copilot@users.noreply.github.com> Date: Sun, 8 Mar 2026 17:58:47 +0000 Subject: [PATCH 3/3] Fix build: use EQ::versions::ClientVersion::RoF2 in cli_zone_state test Co-authored-by: Valorith <76063792+Valorith@users.noreply.github.com> --- zone/cli/tests/cli_zone_state.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/zone/cli/tests/cli_zone_state.cpp b/zone/cli/tests/cli_zone_state.cpp index f3c0833e6..1eb391a81 100644 --- a/zone/cli/tests/cli_zone_state.cpp +++ b/zone/cli/tests/cli_zone_state.cpp @@ -895,7 +895,7 @@ inline void TestClientBuffPersistence() Client loader; loader.SetCharacterId(test_character_id); loader.SetName("buff-persistence-load"); - loader.SetClientVersion(ClientVersion::RoF2); + loader.SetClientVersion(EQ::versions::ClientVersion::RoF2); database.LoadBuffs(&loader); auto loaded_buffs = loader.GetBuffs();