pa/eqemu-server
2
0
Fork 0
mirror of https://github.com/EQEmu/Server.git synced 2026-09-01 07:26:36 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

[Cleanup] Quest API push methods using invalid types. (#2172)

Browse Source 
* [Cleanup] Quest API push methods using invalid types.
- Some push methods were pushing integers as unsigned integers or unsigned integer as integers, this fixes all of that.
- Also cleans up some lines that had multiple function calls on them.

* More cleanup of bools and one expansion name was wrong.
This commit is contained in:
Kinglykrab
2022-05-15 22:14:16 -04:00
committed by GitHub
parent 8554aab2ff
commit 7c1a139991
16 changed files with 454 additions and 288 deletions
Download Patch File Download Diff File Expand all files Collapse all files
zone/perl_mob.cpp
+12 -12
View File
@@ -956,7 +956,7 @@ XS(XS_Mob_FindBuff) {
uint16 spellid = (uint16) SvUV(ST(1));
VALIDATE_THIS_IS_MOB;
RETVAL = THIS->FindBuff(spellid);
ST(0) = boolSV(RETVAL);
ST(0) = boolSV(RETVAL);
sv_2mortal(ST(0));
}
XSRETURN(1);
@@ -1022,7 +1022,7 @@ XS(XS_Mob_FindType) {
}
RETVAL = THIS->FindType(type, bOffensive, threshold);
ST(0) = boolSV(RETVAL);
ST(0) = boolSV(RETVAL);
sv_2mortal(ST(0));
}
XSRETURN(1);
@@ -2830,7 +2830,7 @@ XS(XS_Mob_IsImmuneToSpell) {
Perl_croak(aTHX_ "caster is nullptr, avoiding crash.");
RETVAL = THIS->IsImmuneToSpell(spell_id, caster);
ST(0) = boolSV(RETVAL);
ST(0) = boolSV(RETVAL);
sv_2mortal(ST(0));
}
XSRETURN(1);
@@ -4334,7 +4334,7 @@ XS(XS_Mob_SetAA) {
int charges = (items == 4) ? (int) SvIV(ST(3)) : 0;
VALIDATE_THIS_IS_MOB;
RETVAL = THIS->SetAA(aa_id, points, charges);
ST(0) = boolSV(RETVAL);
ST(0) = boolSV(RETVAL);
sv_2mortal(ST(0));
}
XSRETURN(1);
@@ -4457,7 +4457,7 @@ XS(XS_Mob_EntityVariableExists) {
bool RETVAL;
VALIDATE_THIS_IS_MOB;
RETVAL = THIS->EntityVariableExists(id);
ST(0) = boolSV(RETVAL);
ST(0) = boolSV(RETVAL);
sv_2mortal(ST(0));
}
XSRETURN(1);
@@ -4544,7 +4544,7 @@ XS(XS_Mob_CombatRange) {
Perl_croak(aTHX_ "target is nullptr, avoiding crash.");
RETVAL = THIS->CombatRange(target);
ST(0) = boolSV(RETVAL);
ST(0) = boolSV(RETVAL);
sv_2mortal(ST(0));
}
XSRETURN(1);
@@ -4721,7 +4721,7 @@ XS(XS_Mob_HasNPCSpecialAtk) {
bool RETVAL;
VALIDATE_THIS_IS_MOB;
RETVAL = THIS->HasNPCSpecialAtk(parse);
ST(0) = boolSV(RETVAL);
ST(0) = boolSV(RETVAL);
sv_2mortal(ST(0));
}
XSRETURN(1);
@@ -5677,7 +5677,7 @@ XS(XS_Mob_GetBuffStatValueBySpell) {
RETVAL = THIS->GetBuffStatValueBySpell(spellid, stat);
XSprePUSH;
PUSHi((IV)RETVAL);
PUSHi((IV) RETVAL);
}
XSRETURN(1);
}
@@ -5697,7 +5697,7 @@ XS(XS_Mob_GetBuffStatValueBySlot) {
RETVAL = THIS->GetBuffStatValueBySlot(slot, stat);
XSprePUSH;
PUSHi((IV)RETVAL);
PUSHi((IV) RETVAL);
}
XSRETURN(1);
}
@@ -5858,7 +5858,7 @@ XS(XS_Mob_GetInvisibleLevel) {
VALIDATE_THIS_IS_MOB;
RETVAL = THIS->GetInvisibleLevel();
XSprePUSH;
PUSHu((UV)RETVAL);
PUSHu((UV) RETVAL);
}
XSRETURN(1);
}
@@ -5875,7 +5875,7 @@ XS(XS_Mob_GetInvisibleUndeadLevel) {
VALIDATE_THIS_IS_MOB;
RETVAL = THIS->GetInvisibleUndeadLevel();
XSprePUSH;
PUSHu((UV)RETVAL);
PUSHu((UV) RETVAL);
}
XSRETURN(1);
}
@@ -5910,7 +5910,7 @@ XS(XS_Mob_SeeInvisibleUndead) {
VALIDATE_THIS_IS_MOB;
RETVAL = THIS->SeeInvisibleUndead();
XSprePUSH;
PUSHu((UV)RETVAL);
PUSHu((UV) RETVAL);
}
XSRETURN(1);
}