pa/eqemu-server
2
0
Fork 0
mirror of https://github.com/EQEmu/Server.git synced 2026-08-30 09:37:55 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

[Cleanup] Quest API push methods using invalid types. (#2172)

Browse Source 
* [Cleanup] Quest API push methods using invalid types.
- Some push methods were pushing integers as unsigned integers or unsigned integer as integers, this fixes all of that.
- Also cleans up some lines that had multiple function calls on them.

* More cleanup of bools and one expansion name was wrong.
This commit is contained in:
Kinglykrab
2022-05-15 22:14:16 -04:00
committed by GitHub
parent 8554aab2ff
commit 7c1a139991
16 changed files with 454 additions and 288 deletions
Download Patch File Download Diff File Expand all files Collapse all files
zone/perl_client.cpp
+17 -17
View File
@@ -55,7 +55,7 @@ XS(XS_Client_Save) {
uint8 iCommitNow = (uint8) SvUV(ST(1));
VALIDATE_THIS_IS_CLIENT;
RETVAL = THIS->Save(iCommitNow);
ST(0) = boolSV(RETVAL);
ST(0) = boolSV(RETVAL);
sv_2mortal(ST(0));
}
XSRETURN(1);
@@ -2688,7 +2688,7 @@ XS(XS_Client_DecreaseByID) {
int16 quantity = (int16) SvIV(ST(2));
VALIDATE_THIS_IS_CLIENT;
RETVAL = THIS->DecreaseByID(type, quantity);
ST(0) = boolSV(RETVAL);
ST(0) = boolSV(RETVAL);
sv_2mortal(ST(0));
}
XSRETURN(1);
@@ -2826,7 +2826,7 @@ XS(XS_Client_UseDiscipline) {
uint32 target = (uint32) SvUV(ST(2));
VALIDATE_THIS_IS_CLIENT;
RETVAL = THIS->UseDiscipline(spell_id, target);
ST(0) = boolSV(RETVAL);
ST(0) = boolSV(RETVAL);
sv_2mortal(ST(0));
}
XSRETURN(1);
@@ -2921,7 +2921,7 @@ XS(XS_Client_HasZoneFlag) {
uint32 zone_id = (uint32) SvUV(ST(1));
VALIDATE_THIS_IS_CLIENT;
RETVAL = THIS->HasZoneFlag(zone_id);
ST(0) = boolSV(RETVAL);
ST(0) = boolSV(RETVAL);
sv_2mortal(ST(0));
}
XSRETURN(1);
@@ -3313,7 +3313,7 @@ XS(XS_Client_KeyRingCheck) {
uint32 item_id = (uint32) SvUV(ST(1));
VALIDATE_THIS_IS_CLIENT;
RETVAL = THIS->KeyRingCheck(item_id);;
ST(0) = boolSV(RETVAL);
ST(0) = boolSV(RETVAL);
sv_2mortal(ST(0));
}
XSRETURN(1);
@@ -3705,7 +3705,7 @@ XS(XS_Client_GrantAlternateAdvancementAbility) {
}
RETVAL = THIS->GrantAlternateAdvancementAbility(aa_id, points, ignore_cost);
ST(0) = boolSV(RETVAL);
ST(0) = boolSV(RETVAL);
sv_2mortal(ST(0));
}
XSRETURN(1);
@@ -3810,7 +3810,7 @@ XS(XS_Client_GetSpellIDByBookSlot) {
VALIDATE_THIS_IS_CLIENT;
RETVAL = THIS->GetSpellIDByBookSlot(slot_id);
XSprePUSH;
PUSHi((IV)RETVAL);
PUSHi((IV) RETVAL);
}
XSRETURN(1);
}
@@ -3908,7 +3908,7 @@ XS(XS_Client_IsTaskCompleted) {
int TaskID = (int) SvIV(ST(1));
VALIDATE_THIS_IS_CLIENT;
RETVAL = THIS->IsTaskCompleted(TaskID);
ST(0) = boolSV(RETVAL);
ST(0) = boolSV(RETVAL);
sv_2mortal(ST(0));
}
XSRETURN(1);
@@ -3925,7 +3925,7 @@ XS(XS_Client_IsTaskActive) {
int TaskID = (int) SvIV(ST(1));
VALIDATE_THIS_IS_CLIENT;
RETVAL = THIS->IsTaskActive(TaskID);
ST(0) = boolSV(RETVAL);
ST(0) = boolSV(RETVAL);
sv_2mortal(ST(0));
}
XSRETURN(1);
@@ -3943,7 +3943,7 @@ XS(XS_Client_IsTaskActivityActive) {
int ActivityID = (int) SvIV(ST(2));
VALIDATE_THIS_IS_CLIENT;
RETVAL = THIS->IsTaskActivityActive(TaskID, ActivityID);
ST(0) = boolSV(RETVAL);
ST(0) = boolSV(RETVAL);
sv_2mortal(ST(0));
}
XSRETURN(1);
@@ -4284,7 +4284,7 @@ XS(XS_Client_HasSpellScribed) {
int spell_id = (int) SvUV(ST(1));
VALIDATE_THIS_IS_CLIENT;
RETVAL = THIS->HasSpellScribed(spell_id);
ST(0) = boolSV(RETVAL);
ST(0) = boolSV(RETVAL);
sv_2mortal(ST(0));
}
XSRETURN(1);
@@ -4661,7 +4661,7 @@ XS(XS_Client_GetMoney) {
VALIDATE_THIS_IS_CLIENT;
RETVAL = THIS->GetMoney(type, subtype);
XSprePUSH;
PUSHn((uint32) RETVAL);
PUSHu((UV) RETVAL);
}
XSRETURN(1);
}
@@ -4678,7 +4678,7 @@ XS(XS_Client_GetAccountAge) {
VALIDATE_THIS_IS_CLIENT;
RETVAL = THIS->GetAccountAge();
XSprePUSH;
PUSHn((int) RETVAL);
PUSHi((IV) RETVAL);
}
XSRETURN(1);
}
@@ -4773,7 +4773,7 @@ XS(XS_Client_GetClientMaxLevel) {
VALIDATE_THIS_IS_CLIENT;
RETVAL = THIS->GetClientMaxLevel();
XSprePUSH;
PUSHu((UV)RETVAL);
PUSHu((UV) RETVAL);
}
XSRETURN(1);
}
@@ -6019,7 +6019,7 @@ XS(XS_Client_GetEnvironmentDamageModifier) {
VALIDATE_THIS_IS_CLIENT;
RETVAL = THIS->GetEnvironmentDamageModifier();
XSprePUSH;
PUSHi((IV)RETVAL);
PUSHi((IV) RETVAL);
}
XSRETURN(1);
}
@@ -6156,7 +6156,7 @@ XS(XS_Client_CountAugmentEquippedByID) {
VALIDATE_THIS_IS_CLIENT;
quantity = THIS->GetInv().CountAugmentEquippedByID(item_id);
XSprePUSH;
PUSHi((IV)quantity);
PUSHi((IV) quantity);
}
XSRETURN(1);
}
@@ -6228,7 +6228,7 @@ XS(XS_Client_CountItemEquippedByID) {
VALIDATE_THIS_IS_CLIENT;
quantity = THIS->GetInv().CountItemEquippedByID(item_id);
XSprePUSH;
PUSHi((IV)quantity);
PUSHi((IV) quantity);
}
XSRETURN(1);
}