pa/eqemu-server
2
0
Fork 0
mirror of https://github.com/EQEmu/Server.git synced 2025-12-12 09:31:30 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

_GetFeeGuildID converted to QueryDatabase

Browse Source
This commit is contained in:
Arthur Ice 2014-08-17 11:11:56 -07:00
parent a2d4376763
commit 7b440bbd9f
1 changed files with 28 additions and 16 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

44
common/guild_base.cpp
View File

@ -313,27 +313,39 @@ uint32 BaseGuildManager::_GetFreeGuildID() {
return(GUILD_NONE); return(GUILD_NONE);
} }
char errbuf[MYSQL_ERRMSG_SIZE]; std::string query;
char query[100];
MYSQL_RES *result;
//this has got to be one of the more retarded things I have seen. //this has got to be one of the more retarded things I have seen.
//none the less, im too lazy to rewrite it right now. //none the less, im too lazy to rewrite it right now.
//possibly:
//
// SELECT t1.id + 1
// FROM guilds t1
// WHERE NOT EXISTS (
// SELECT *
// FROM guilds t2
// WHERE t2.id = t1.id + 1
// )
// LIMIT 1
//
// Seems likely what we should be doing is auto incrementing the guild table
// inserting, then getting the id. NOT getting a free id then inserting.
// could be a race condition.
uint16 x; for (auto index = 1; index < MAX_NUMBER_GUILDS; ++index)
for (x = 1; x < MAX_NUMBER_GUILDS; x++) { {
snprintf(query, 100, "SELECT id FROM guilds where id=%i;", x); query = StringFormat("SELECT id FROM guilds where id=%i;", index);
auto results = m_db->QueryDatabase(query);
if (m_db->RunQuery(query, strlen(query), errbuf, &result)) { if (!results.Success())
if (mysql_num_rows(result) == 0) { {
mysql_free_result(result); LogFile->write(EQEMuLog::Error, "Error in _GetFreeGuildID query '%s': %s", query.c_str(), results.ErrorMessage().c_str());
_log(GUILDS__DB, "Located free guild ID %d in the database", x); continue;
return x;
} }
mysql_free_result(result);
} if (results.RowCount() == 0)
else { {
LogFile->write(EQEMuLog::Error, "Error in _GetFreeGuildID query '%s': %s", query, errbuf); _log(GUILDS__DB, "Located free guild ID %d in the database", index);
return index;
} }
} }