[Repositories] Add more precise types to repository generator (#2391)

* Make utils/scripts/generators/repository-generator.pl aware of more
datatypes

This adds support for unsigned and more integer types. It also avoids
using parsing functions that require casting (still needed in some
cases)

Having the data types in the Repository structs better map to the types
in the database will allow us to avoid casting when we pull data out of
them. And as a benefit, assume something is wrong if we do :)

Hopefully clean up some warnings due to casting too.

Co-authored-by: Akkadius <akkadius1@gmail.com>
This commit is contained in:
Michael Cook (mackal)
2022-08-31 01:04:27 -04:00
committed by GitHub
parent fcf01f6d87
commit 6f7fa98996
183 changed files with 7849 additions and 7818 deletions
@@ -19,13 +19,13 @@
class BaseForageRepository {
public:
struct Forage {
int id;
int zoneid;
int Itemid;
int level;
int chance;
int min_expansion;
int max_expansion;
int32_t id;
int32_t zoneid;
int32_t Itemid;
int16_t level;
int16_t chance;
int8_t min_expansion;
int8_t max_expansion;
std::string content_flags;
std::string content_flags_disabled;
};
@@ -146,13 +146,13 @@ public:
if (results.RowCount() == 1) {
Forage e{};
e.id = atoi(row[0]);
e.zoneid = atoi(row[1]);
e.Itemid = atoi(row[2]);
e.level = atoi(row[3]);
e.chance = atoi(row[4]);
e.min_expansion = atoi(row[5]);
e.max_expansion = atoi(row[6]);
e.id = static_cast<int32_t>(atoi(row[0]));
e.zoneid = static_cast<int32_t>(atoi(row[1]));
e.Itemid = static_cast<int32_t>(atoi(row[2]));
e.level = static_cast<int16_t>(atoi(row[3]));
e.chance = static_cast<int16_t>(atoi(row[4]));
e.min_expansion = static_cast<int8_t>(atoi(row[5]));
e.max_expansion = static_cast<int8_t>(atoi(row[6]));
e.content_flags = row[7] ? row[7] : "";
e.content_flags_disabled = row[8] ? row[8] : "";
@@ -297,13 +297,13 @@ public:
for (auto row = results.begin(); row != results.end(); ++row) {
Forage e{};
e.id = atoi(row[0]);
e.zoneid = atoi(row[1]);
e.Itemid = atoi(row[2]);
e.level = atoi(row[3]);
e.chance = atoi(row[4]);
e.min_expansion = atoi(row[5]);
e.max_expansion = atoi(row[6]);
e.id = static_cast<int32_t>(atoi(row[0]));
e.zoneid = static_cast<int32_t>(atoi(row[1]));
e.Itemid = static_cast<int32_t>(atoi(row[2]));
e.level = static_cast<int16_t>(atoi(row[3]));
e.chance = static_cast<int16_t>(atoi(row[4]));
e.min_expansion = static_cast<int8_t>(atoi(row[5]));
e.max_expansion = static_cast<int8_t>(atoi(row[6]));
e.content_flags = row[7] ? row[7] : "";
e.content_flags_disabled = row[8] ? row[8] : "";
@@ -330,13 +330,13 @@ public:
for (auto row = results.begin(); row != results.end(); ++row) {
Forage e{};
e.id = atoi(row[0]);
e.zoneid = atoi(row[1]);
e.Itemid = atoi(row[2]);
e.level = atoi(row[3]);
e.chance = atoi(row[4]);
e.min_expansion = atoi(row[5]);
e.max_expansion = atoi(row[6]);
e.id = static_cast<int32_t>(atoi(row[0]));
e.zoneid = static_cast<int32_t>(atoi(row[1]));
e.Itemid = static_cast<int32_t>(atoi(row[2]));
e.level = static_cast<int16_t>(atoi(row[3]));
e.chance = static_cast<int16_t>(atoi(row[4]));
e.min_expansion = static_cast<int8_t>(atoi(row[5]));
e.max_expansion = static_cast<int8_t>(atoi(row[6]));
e.content_flags = row[7] ? row[7] : "";
e.content_flags_disabled = row[8] ? row[8] : "";