From 6cb2fdd7371a8ba161723b6f1e972cccd6a375e9 Mon Sep 17 00:00:00 2001
From: Uleat <uleat.charismata@gmail.com>
Date: Fri, 15 Jul 2016 19:32:46 -0400
Subject: [PATCH] Changed constructor call for stringstream in
 ClientTaskState::EnableTask/DisableTask (write position issues)

---
 zone/tasks.cpp | 14 ++++++++------
 1 file changed, 8 insertions(+), 6 deletions(-)

diff --git a/zone/tasks.cpp b/zone/tasks.cpp
index 7420f5c18..40e7d8b67 100644
--- a/zone/tasks.cpp
+++ b/zone/tasks.cpp
@@ -718,9 +718,10 @@ void ClientTaskState::EnableTask(int characterID, int taskCount, int *tasks) {
 	if(tasksEnabled.empty() )
         return;
 
-	std::stringstream queryStream("REPLACE INTO character_enabledtasks (charid, taskid) VALUES ");
+	std::stringstream queryStream;
+	queryStream << "REPLACE INTO character_enabledtasks (charid, taskid) VALUES ";
 	for(unsigned int i=0; i<tasksEnabled.size(); i++)
-		queryStream << ( i ? ", " : "" ) <<  StringFormat("(%i, %i)", characterID, tasksEnabled[i]);
+		queryStream << (i ? ", " : "") <<  StringFormat("(%i, %i)", characterID, tasksEnabled[i]);
 
     std::string query = queryStream.str();
 
@@ -729,7 +730,7 @@ void ClientTaskState::EnableTask(int characterID, int taskCount, int *tasks) {
 		database.QueryDatabase(query);
 	}
 	else {
-		Log.Out(Logs::General, Logs::Tasks, "[UPDATE] EnableTask called for characterID: %u .. but, no tasks exist!", characterID);
+		Log.Out(Logs::General, Logs::Tasks, "[UPDATE] EnableTask called for characterID: %u .. but, no tasks exist", characterID);
 	}
 }
 
@@ -768,10 +769,11 @@ void ClientTaskState::DisableTask(int charID, int taskCount, int *taskList) {
 	if(tasksDisabled.empty())
         return;
 
-	std::stringstream queryStream(StringFormat("DELETE FROM character_enabledtasks WHERE charid = %i AND (", charID));
+	std::stringstream queryStream;
+	queryStream << StringFormat("DELETE FROM character_enabledtasks WHERE charid = %i AND (", charID);
 
 	for(unsigned int i=0; i<tasksDisabled.size(); i++)
-        queryStream << (i ? StringFormat("taskid = %i ", tasksDisabled[i]): StringFormat("OR taskid = %i ", tasksDisabled[i]));
+        queryStream << (i ? StringFormat("taskid = %i ", tasksDisabled[i]) : StringFormat("OR taskid = %i ", tasksDisabled[i]));
 
 	queryStream << ")";
 
@@ -782,7 +784,7 @@ void ClientTaskState::DisableTask(int charID, int taskCount, int *taskList) {
 		database.QueryDatabase(query);
 	}
 	else {
-		Log.Out(Logs::General, Logs::Tasks, "[UPDATE] DisableTask called for characterID: %u .. but, no tasks exist!", charID);
+		Log.Out(Logs::General, Logs::Tasks, "[UPDATE] DisableTask called for characterID: %u .. but, no tasks exist", charID);
 	}
 }