diff --git a/zone/client.h b/zone/client.h index 72449bb8d..4aa0da353 100644 --- a/zone/client.h +++ b/zone/client.h @@ -1358,7 +1358,7 @@ public: } inline bool SaveTaskState() { - return TaskManager::Instance() != nullptr && TaskManager::Instance()->SaveClientState(this, task_state); + return TaskManager::Instance()->SaveClientState(this, task_state); } inline bool IsTaskStateLoaded() { return task_state != nullptr; } inline bool IsTaskActive(int task_id) { return task_state != nullptr && task_state->IsTaskActive(task_id); } @@ -1432,13 +1432,13 @@ public: } inline void TaskSetSelector(Mob* mob, int task_set_id, bool ignore_cooldown) { - if (TaskManager::Instance() && task_state) { + if (task_state) { TaskManager::Instance()->TaskSetSelector(this, mob, task_set_id, ignore_cooldown); } } inline void TaskQuestSetSelector(Mob* mob, const std::vector& tasks, bool ignore_cooldown) { - if (TaskManager::Instance() && task_state) { + if (task_state) { TaskManager::Instance()->TaskQuestSetSelector(this, mob, tasks, ignore_cooldown); } } diff --git a/zone/entity.cpp b/zone/entity.cpp index 03cfba3d2..9a93a3620 100644 --- a/zone/entity.cpp +++ b/zone/entity.cpp @@ -4175,10 +4175,6 @@ void EntityList::ProcessProximitySay(const char *message, Client *c, uint8 langu void EntityList::SaveAllClientsTaskState() { - if (!TaskManager::Instance()) { - return; - } - auto it = client_list.begin(); while (it != client_list.end()) { Client *client = it->second; @@ -4192,9 +4188,6 @@ void EntityList::SaveAllClientsTaskState() void EntityList::ReloadAllClientsTaskState(int task_id) { - if (!TaskManager::Instance()) - return; - auto it = client_list.begin(); while (it != client_list.end()) { Client *client = it->second; diff --git a/zone/task_client_state.cpp b/zone/task_client_state.cpp index 91b4c9cb0..f3e5deaeb 100644 --- a/zone/task_client_state.cpp +++ b/zone/task_client_state.cpp @@ -521,11 +521,6 @@ bool ClientTaskState::CanUpdate(Client* client, const TaskUpdateFilter& filter, int ClientTaskState::UpdateTasks(Client* client, const TaskUpdateFilter& filter, int count) { - if (!TaskManager::Instance()) - { - return 0; - } - int max_updated = 0; for (const auto& client_task : m_active_tasks) @@ -593,11 +588,6 @@ int ClientTaskState::UpdateTasks(Client* client, const TaskUpdateFilter& filter, std::pair ClientTaskState::FindTask(Client* client, const TaskUpdateFilter& filter) const { - if (!TaskManager::Instance()) - { - return std::make_pair(0, 0); - } - for (const auto& client_task : m_active_tasks) { const auto task = GetTaskData(client_task); @@ -1973,7 +1963,7 @@ void ClientTaskState::AcceptNewTask( bool enforce_level_requirement ) { - if (!TaskManager::Instance() || task_id < 0) { + if (task_id < 0) { client->Message(Chat::Red, "Task system not functioning, or task_id %i out of range.", task_id); return; } @@ -2455,10 +2445,6 @@ void ClientTaskState::SyncSharedTaskZoneClientDoneCountState( bool ClientTaskState::HasActiveTasks() { - if (!TaskManager::Instance()) { - return false; - } - if (m_active_task.task_id != TASKSLOTEMPTY) { return true; } @@ -2495,7 +2481,7 @@ void ClientTaskState::LockSharedTask(Client* client, bool lock) void ClientTaskState::EndSharedTask(Client* client, bool send_fail) { - if (TaskManager::Instance() && m_active_shared_task.task_id != TASKSLOTEMPTY) + if (m_active_shared_task.task_id != TASKSLOTEMPTY) { TaskManager::Instance()->EndSharedTask(*client, m_active_shared_task.task_id, send_fail); }