pa/eqemu-server
2
0
Fork 0
mirror of https://github.com/EQEmu/Server.git synced 2026-01-19 14:03:52 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Make ChooseRandom more idiomatic, the fact that the code can return a SV of anytype makes it a bit dangerous, good canidate for rewriting as a plugin

Browse Source
This commit is contained in:
KimLS 2020-05-25 20:56:49 -07:00
parent db072e767a
commit 5e9bf3b044
1 changed files with 4 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
zone/embparser_api.cpp
View File

@ -1618,11 +1618,12 @@ XS(XS__ChooseRandom) {
if (items < 1)
Perl_croak(aTHX_ "Usage: quest::ChooseRandom(option1, option2, option3, option4, option5...[no limit])");
dXSTARG;
int index = zone->random.Int(0, items - 1);
SV *RETVAL = ST(index);
SV *tmp = ST(0);
ST(0) = ST(index);
ST(index) = tmp;
XSprePUSH;
PUSHs(RETVAL);
XSRETURN(1); //return 1 element from the stack (ST(0))
}