[Cleanup] Mask GM Show Buff message behind EntityVariable (#4419)

* [Cleanup] Mask GM Show Buff message behind EntityVariable

Removes the spam of "Your GM flag allows you to always see your targets' buffs." for GMs every time a buff lands on a target.

It will now lock to an Entity Variable and only show once per zone.

* Convert string to constexpr

* Switch from string to char
This commit is contained in:
nytmyr 2024-07-22 11:51:41 -05:00 committed by GitHub
parent 1e5abc456b
commit 563f7d5564
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
3 changed files with 8 additions and 1 deletions

View File

@ -793,6 +793,8 @@ void Client::CompleteConnect()
parse->EventPlayer(EVENT_ENTER_ZONE, this, "", 0); parse->EventPlayer(EVENT_ENTER_ZONE, this, "", 0);
} }
DeleteEntityVariable(SEE_BUFFS_FLAG);
// the way that the client deals with positions during the initial spawn struct // the way that the client deals with positions during the initial spawn struct
// is subtly different from how it deals with getting a position update // is subtly different from how it deals with getting a position update
// if a mob is slightly in the wall or slightly clipping a floor they will be // if a mob is slightly in the wall or slightly clipping a floor they will be

View File

@ -1655,7 +1655,10 @@ void EntityList::QueueClientsByTarget(Mob *sender, const EQApplicationPacket *ap
Send = clear_target_window; Send = clear_target_window;
if (c->GetGM() || RuleB(Spells, AlwaysSendTargetsBuffs)) { if (c->GetGM() || RuleB(Spells, AlwaysSendTargetsBuffs)) {
if (c->GetGM()) { if (c->GetGM()) {
c->Message(Chat::White, "Your GM flag allows you to always see your targets' buffs."); if (!c->EntityVariableExists(SEE_BUFFS_FLAG)) {
c->Message(Chat::White, "Your GM flag allows you to always see your targets' buffs.");
c->SetEntityVariable(SEE_BUFFS_FLAG, "1");
}
} }
Send = !clear_target_window; Send = !clear_target_window;

View File

@ -60,6 +60,8 @@ class Bot;
extern EntityList entity_list; extern EntityList entity_list;
constexpr const char* SEE_BUFFS_FLAG = "see_buffs_flag";
class Entity class Entity
{ {
public: public: