[Cleanup] Remove unnecessary reference types (#4212)

Minor clean up from #4054 and #4181
This commit is contained in:
JJ 2024-03-27 22:17:21 -04:00 committed by GitHub
parent 20d9417628
commit 52417023f8
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
4 changed files with 12 additions and 12 deletions

View File

@ -632,7 +632,7 @@ uint32 Database::GetAccountIDByName(const std::string& account_name, const std::
return e.id;
}
const std::string& Database::GetAccountName(uint32 account_id, uint32* lsaccount_id)
const std::string Database::GetAccountName(uint32 account_id, uint32* lsaccount_id)
{
const auto& e = AccountRepository::FindOne(*this, account_id);
@ -647,28 +647,28 @@ const std::string& Database::GetAccountName(uint32 account_id, uint32* lsaccount
return e.name;
}
const std::string& Database::GetCharName(uint32 character_id)
const std::string Database::GetCharName(uint32 character_id)
{
const auto& e = CharacterDataRepository::FindOne(*this, character_id);
return e.id ? e.name : std::string();
}
const std::string& Database::GetCharNameByID(uint32 character_id)
const std::string Database::GetCharNameByID(uint32 character_id)
{
const auto& e = CharacterDataRepository::FindOne(*this, character_id);
return e.id ? e.name : std::string();
}
const std::string& Database::GetNPCNameByID(uint32 npc_id)
const std::string Database::GetNPCNameByID(uint32 npc_id)
{
const auto& e = NpcTypesRepository::FindOne(*this, npc_id);
return e.id ? e.name : std::string();
}
const std::string& Database::GetCleanNPCNameByID(uint32 npc_id)
const std::string Database::GetCleanNPCNameByID(uint32 npc_id)
{
const auto& e = NpcTypesRepository::FindOne(*this, npc_id);

View File

@ -125,11 +125,11 @@ public:
uint32 GetGroupIDByCharID(uint32 character_id);
uint32 GetRaidIDByCharID(uint32 character_id);
const std::string& GetAccountName(uint32 account_id, uint32* lsaccount_id = 0);
const std::string& GetCharName(uint32 character_id);
const std::string& GetCharNameByID(uint32 character_id);
const std::string& GetNPCNameByID(uint32 npc_id);
const std::string& GetCleanNPCNameByID(uint32 npc_id);
const std::string GetAccountName(uint32 account_id, uint32* lsaccount_id = 0);
const std::string GetCharName(uint32 character_id);
const std::string GetCharNameByID(uint32 character_id);
const std::string GetNPCNameByID(uint32 npc_id);
const std::string GetCleanNPCNameByID(uint32 npc_id);
void LoginIP(uint32 account_id, const std::string& login_ip);
/* Instancing */

View File

@ -1113,7 +1113,7 @@ uint8 Mob::GetArchetype() const
return Archetype::Hybrid;
}
const std::string& Mob::GetArchetypeName()
const std::string Mob::GetArchetypeName()
{
switch (GetArchetype()) {
case Archetype::Hybrid:

View File

@ -842,7 +842,7 @@ public:
bool IsPureMeleeClass() const;
bool IsWisdomCasterClass() const;
uint8 GetArchetype() const;
const std::string& GetArchetypeName();
const std::string GetArchetypeName();
void SetZone(uint32 zone_id, uint32 instance_id);
void SendStatsWindow(Client* c, bool use_window);
void ShowStats(Client* client);