pa/eqemu-server
2
0
Fork 0
mirror of https://github.com/EQEmu/Server.git synced 2026-04-11 08:52:27 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

[Crash] Fix crash issue with dropping items and order of operations (#2939)

Browse Source 
Should wait to null out invalid_drop until after it is used in log message.
This commit is contained in:
JJ 2023-02-15 21:55:15 -05:00 committed by GitHub
parent 2ae795fd61
commit 4a64048744
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 3 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
zone/inventory.cpp
View File

@ -848,13 +848,14 @@ void Client::DropItem(int16 slot_id, bool recurse)
} }
} }
} }
invalid_drop = nullptr;
std::string message = fmt::format( std::string message = fmt::format(
"Tried to drop an item on the ground that was no-drop! item_name [{}] item_id ({})", "Tried to drop an item on the ground that was no-drop! item_name [{}] item_id ({})",
invalid_drop->GetItem()->Name, invalid_drop->GetItem()->Name,
invalid_drop->GetItem()->ID invalid_drop->GetItem()->ID
); );
invalid_drop = nullptr;
RecordPlayerEventLog(PlayerEvent::POSSIBLE_HACK, PlayerEvent::PossibleHackEvent{.message = message}); RecordPlayerEventLog(PlayerEvent::POSSIBLE_HACK, PlayerEvent::PossibleHackEvent{.message = message});
GetInv().DeleteItem(slot_id); GetInv().DeleteItem(slot_id);
return; return;