pa/eqemu-server
2
0
Fork 0
mirror of https://github.com/EQEmu/Server.git synced 2025-12-18 15:31:33 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Cleanup Database::CheckInstanceExists, use just one column instead of * as storing more results than you need to is generally slower

Browse Source
This commit is contained in:
Akkadius 2015-01-24 23:02:51 -06:00
parent f4a25b0331
commit 3b7ea7fe24
1 changed files with 5 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
common/database.cpp
View File

@ -3861,7 +3861,7 @@ bool Database::RemoveClientsFromInstance(uint16 instance_id)
} }
bool Database::CheckInstanceExists(uint16 instance_id) { bool Database::CheckInstanceExists(uint16 instance_id) {
std::string query = StringFormat("SELECT * FROM instance_list where id=%u", instance_id); std::string query = StringFormat("SELECT `id` FROM `instance_list` WHERE `id` = %u", instance_id);
auto results = QueryDatabase(query); auto results = QueryDatabase(query);
if (!results.Success()) if (!results.Success())
@ -4175,16 +4175,13 @@ bool Database::GetAdventureStats(uint32 char_id, AdventureStats_Struct *as)
return true; return true;
} }
uint32 Database::GetGuildIDByCharID(uint32 char_id) uint32 Database::GetGuildIDByCharID(uint32 character_id)
{ {
std::string query = StringFormat("SELECT guild_id FROM guild_members WHERE char_id='%i'", character_id);
std::string query = StringFormat("SELECT guild_id FROM guild_members WHERE char_id='%i'", char_id);
auto results = QueryDatabase(query); auto results = QueryDatabase(query);
if (!results.Success()) if (!results.Success())
{
return 0; return 0;
}
if (results.RowCount() == 0) if (results.RowCount() == 0)
return 0; return 0;
@ -4193,7 +4190,8 @@ uint32 Database::GetGuildIDByCharID(uint32 char_id)
return atoi(row[0]); return atoi(row[0]);
} }
void Database::LoadLogSettings(EQEmuLogSys::LogSettings* log_settings){ void Database::LoadLogSettings(EQEmuLogSys::LogSettings* log_settings)
{
std::string query = std::string query =
"SELECT " "SELECT "
"log_category_id, " "log_category_id, "