diff --git a/common/eq_constants.h b/common/eq_constants.h index 14f695069..a6c98e2ba 100644 --- a/common/eq_constants.h +++ b/common/eq_constants.h @@ -55,7 +55,7 @@ enum ItemClassTypes ** ** (ref: database and eqstr_us.txt) ** -** (Looking at a recent database, it's possible that some of the item values may be off [10-27-2013] -U) +** (Looking at a recent database, it's possible that some of the item values may be off [10-27-2013]) */ enum ItemUseTypes : uint8 { diff --git a/common/eq_packet_structs.h b/common/eq_packet_structs.h index 65d6fba3b..57dfe5482 100644 --- a/common/eq_packet_structs.h +++ b/common/eq_packet_structs.h @@ -189,7 +189,7 @@ struct CharacterSelectEntry_Struct uint8 Tutorial; // Seen 1 for new char or 0 for existing uint32 DrakkinHeritage; uint8 Unknown1; // Seen 0 - uint8 Enabled; // Originally labeled as 'CharEnabled' - unknown purpose and setting -U + uint8 Enabled; // Originally labeled as 'CharEnabled' - unknown purpose and setting uint32 LastLogin; uint8 Unknown2; // Seen 0 }; @@ -1265,7 +1265,7 @@ struct ZoneChange_Struct { // Whatever you send to the client in RequestClientZoneChange_Struct.type, the client will send back // to the server in ZoneChange_Struct.zone_reason. My guess is this is a memo field of sorts. -// WildcardX 27 January 2008 +// 27 January 2008 struct RequestClientZoneChange_Struct { /*00*/ uint16 zone_id; @@ -2421,11 +2421,11 @@ struct InspectResponse_Struct { /*004*/ uint32 playerid; /*008*/ char itemnames[23][64]; /*1480*/uint32 itemicons[23]; -/*1572*/char text[288]; // Max number of chars in Inspect Window appears to be 254 // Msg struct property is 256 (254 + '\0' is my guess) -U +/*1572*/char text[288]; // Max number of chars in Inspect Window appears to be 254 // Msg struct property is 256 (254 + '\0' is my guess) /*1860*/ }; -//OP_InspectMessageUpdate - Size: 256 (SoF+ clients after self-inspect window is closed) -U +//OP_InspectMessageUpdate - Size: 256 (SoF+ clients after self-inspect window is closed) struct InspectMessage_Struct { /*000*/ char text[256]; /*256*/ @@ -2534,7 +2534,7 @@ struct BookRequest_Struct { ** */ struct Object_Struct { -/*00*/ uint32 linked_list_addr[2];// They are, get this, prev and next, ala linked list +/*00*/ uint32 linked_list_addr[2];// They are, get this, prev and next, ala linked list /*08*/ uint16 unknown008; // /*10*/ uint16 unknown010; // /*12*/ uint32 drop_id; // Unique object id for zone @@ -2553,8 +2553,8 @@ struct Object_Struct { /*88*/ uint32 spawn_id; // Spawn Id of client interacting with object /*92*/ }; -// 01 = generic drop, 02 = armor, 19 = weapon -//[13:40] and 0xff seems to be indicative of the tradeskill/openable items that end up returning the old style item type in the OP_OpenObject +// 01 = generic drop, 02 = armor, 19 = weapon +//[13:40] and 0xff seems to be indicative of the tradeskill/openable items that end up returning the old style item type in the OP_OpenObject /* ** Click Object Struct @@ -2611,7 +2611,7 @@ struct CloseContainer_Struct { */ struct Door_Struct { -/*0000*/ char name[32]; // Filename of Door // Was 10char long before... added the 6 in the next unknown to it: Daeken M. BlackBlade //changed both to 32: Trevius +/*0000*/ char name[32]; // Filename of Door // Was 10char long before... added the 6 in the next unknown to it //changed both to 32 /*0032*/ float yPos; // y loc /*0036*/ float xPos; // x loc /*0040*/ float zPos; // z loc diff --git a/common/item.cpp b/common/item.cpp index 0e2f0f574..4f7a81703 100644 --- a/common/item.cpp +++ b/common/item.cpp @@ -660,7 +660,7 @@ int16 Inventory::FindFreeSlotForTradeItem(const ItemInst* inst) { // Do not arbitrarily use this function..it is designed for use with Client::ResetTrade() and Client::FinishTrade(). // If you have a need, use it..but, understand it is not a compatible replacement for Inventory::FindFreeSlot(). // - // I'll probably implement a bitmask in the new inventory system to avoid having to adjust stack bias -U + // I'll probably implement a bitmask in the new inventory system to avoid having to adjust stack bias if (!inst || !inst->GetID()) return INVALID_INDEX; @@ -1232,7 +1232,7 @@ int16 Inventory::_HasItem(ItemInstQueue& iqueue, uint32 item_id, uint8 quantity) // found, it is presented as being available on the cursor. In cases of a parity check, this // is sufficient. However, in cases where referential criteria is considered, this can lead // to unintended results. Funtionality should be observed when referencing the return value - // of this query -U + // of this query uint8 quantity_found = 0; @@ -2148,7 +2148,7 @@ ItemInst* ItemInst::Clone() const } bool ItemInst::IsSlotAllowed(int16 slot_id) const { - // 'SupportsContainers' and 'slot_id > 21' previously saw the reassigned PowerSource slot (9999 to 22) as valid -U + // 'SupportsContainers' and 'slot_id > 21' previously saw the reassigned PowerSource slot (9999 to 22) as valid if (!m_item) { return false; } else if (Inventory::SupportsContainers(slot_id)) { return true; } else if (m_item->Slots & (1 << slot_id)) { return true; } diff --git a/common/patches/rof.cpp b/common/patches/rof.cpp index f47d55c89..22414d6e5 100644 --- a/common/patches/rof.cpp +++ b/common/patches/rof.cpp @@ -4925,7 +4925,7 @@ namespace RoF slot_id = legacy::SLOT_TRADESKILL; // 1000 } emu->container_slot = slot_id; - emu->guildtribute_slot = RoFToServerSlot(eq->guildtribute_slot); // this should only return INVALID_INDEX until implemented -U + emu->guildtribute_slot = RoFToServerSlot(eq->guildtribute_slot); // this should only return INVALID_INDEX until implemented FINISH_DIRECT_DECODE(); } diff --git a/common/patches/rof2.cpp b/common/patches/rof2.cpp index c03c8cd30..59c0258a9 100644 --- a/common/patches/rof2.cpp +++ b/common/patches/rof2.cpp @@ -5123,7 +5123,7 @@ namespace RoF2 slot_id = legacy::SLOT_TRADESKILL; // 1000 } emu->container_slot = slot_id; - emu->guildtribute_slot = RoF2ToServerSlot(eq->guildtribute_slot); // this should only return INVALID_INDEX until implemented -U + emu->guildtribute_slot = RoF2ToServerSlot(eq->guildtribute_slot); // this should only return INVALID_INDEX until implemented FINISH_DIRECT_DECODE(); } diff --git a/common/patches/rof2_structs.h b/common/patches/rof2_structs.h index a00991a70..79da918b9 100644 --- a/common/patches/rof2_structs.h +++ b/common/patches/rof2_structs.h @@ -193,7 +193,7 @@ struct CharacterSelectEntry_Struct /*0000*/ uint8 Tutorial; // Seen 1 for new char or 0 for existing /*0000*/ uint32 DrakkinHeritage; /*0000*/ uint8 Unknown1; // Seen 0 -/*0000*/ uint8 Enabled; // Swapped position with 'GoHome' 02/23/2015 -U +/*0000*/ uint8 Enabled; // Swapped position with 'GoHome' 02/23/2015 /*0000*/ uint32 LastLogin; /*0000*/ uint8 Unknown2; // Seen 0 }; @@ -3616,7 +3616,7 @@ struct Split_Struct */ struct NewCombine_Struct { /*00*/ ItemSlotStruct container_slot; -/*12*/ ItemSlotStruct guildtribute_slot; // Slot type is 8? (MapGuildTribute = 8 -U) +/*12*/ ItemSlotStruct guildtribute_slot; // Slot type is 8? (MapGuildTribute = 8) /*24*/ }; @@ -4552,7 +4552,7 @@ struct ItemSecondaryBodyStruct uint32 augtype; // swapped augrestrict and augdistiller positions // (this swap does show the proper augment restrictions in Item Information window now) - // unsure what the purpose of augdistiller is at this time -U 3/17/2014 + // unsure what the purpose of augdistiller is at this time 3/17/2014 int32 augrestrict2; // New to December 10th 2012 client - Hidden Aug Restriction uint32 augrestrict; AugSlotStruct augslots[6]; diff --git a/common/patches/rof_structs.h b/common/patches/rof_structs.h index 42845a244..a623c7cf4 100644 --- a/common/patches/rof_structs.h +++ b/common/patches/rof_structs.h @@ -193,7 +193,7 @@ struct CharacterSelectEntry_Struct /*0000*/ uint8 Tutorial; // Seen 1 for new char or 0 for existing /*0000*/ uint32 DrakkinHeritage; /*0000*/ uint8 Unknown1; // Seen 0 -/*0000*/ uint8 Enabled; // Swapped position with 'GoHome' 02/23/2015 -U +/*0000*/ uint8 Enabled; // Swapped position with 'GoHome' 02/23/2015 /*0000*/ uint32 LastLogin; /*0000*/ uint8 Unknown2; // Seen 0 }; @@ -3617,7 +3617,7 @@ struct Split_Struct */ struct NewCombine_Struct { /*00*/ ItemSlotStruct container_slot; -/*12*/ ItemSlotStruct guildtribute_slot; // Slot type is 8? (MapGuildTribute = 8 -U) +/*12*/ ItemSlotStruct guildtribute_slot; // Slot type is 8? (MapGuildTribute = 8) /*24*/ }; @@ -4554,7 +4554,7 @@ struct ItemSecondaryBodyStruct uint32 augtype; // swapped augrestrict and augdistiller positions // (this swap does show the proper augment restrictions in Item Information window now) - // unsure what the purpose of augdistiller is at this time -U 3/17/2014 + // unsure what the purpose of augdistiller is at this time 3/17/2014 uint32 augdistiller; // New to December 10th 2012 client - NEW uint32 augrestrict; AugSlotStruct augslots[6]; diff --git a/common/patches/sod_structs.h b/common/patches/sod_structs.h index 274cfe876..ef4dd32cb 100644 --- a/common/patches/sod_structs.h +++ b/common/patches/sod_structs.h @@ -2371,7 +2371,7 @@ struct BookRequest_Struct { ** */ struct Object_Struct { -/*00*/ uint32 linked_list_addr[2];// They are, get this, prev and next, ala linked list +/*00*/ uint32 linked_list_addr[2];// They are, get this, prev and next, ala linked list /*08*/ uint32 unknown008; // Something related to the linked list? /*12*/ uint32 drop_id; // Unique object id for zone /*16*/ uint16 zone_id; // Redudant, but: Zone the object appears in @@ -2391,8 +2391,8 @@ struct Object_Struct { /*100*/ uint32 spawn_id; // Spawn Id of client interacting with object /*104*/ }; -// 01 = generic drop, 02 = armor, 19 = weapon -//[13:40] and 0xff seems to be indicative of the tradeskill/openable items that end up returning the old style item type in the OP_OpenObject +//01 = generic drop, 02 = armor, 19 = weapon +//[13:40] and 0xff seems to be indicative of the tradeskill/openable items that end up returning the old style item type in the OP_OpenObject /* ** Click Object Struct diff --git a/common/patches/sof_structs.h b/common/patches/sof_structs.h index 23b080f0c..51dbef1f5 100644 --- a/common/patches/sof_structs.h +++ b/common/patches/sof_structs.h @@ -2305,7 +2305,7 @@ struct BookRequest_Struct { ** */ struct Object_Struct { -/*00*/ uint32 linked_list_addr[2];// They are, get this, prev and next, ala linked list +/*00*/ uint32 linked_list_addr[2];// They are, get this, prev and next, ala linked list /*08*/ uint32 unknown008; // Something related to the linked list? /*12*/ uint32 drop_id; // Unique object id for zone /*16*/ uint16 zone_id; // Redudant, but: Zone the object appears in @@ -2325,8 +2325,8 @@ struct Object_Struct { /*100*/ uint32 spawn_id; // Spawn Id of client interacting with object /*104*/ }; -// 01 = generic drop, 02 = armor, 19 = weapon -//[13:40] and 0xff seems to be indicative of the tradeskill/openable items that end up returning the old style item type in the OP_OpenObject +//01 = generic drop, 02 = armor, 19 = weapon +//[13:40] and 0xff seems to be indicative of the tradeskill/openable items that end up returning the old style item type in the OP_OpenObject /* ** Click Object Struct diff --git a/common/patches/titanium.cpp b/common/patches/titanium.cpp index b183acf4b..c8eeea36a 100644 --- a/common/patches/titanium.cpp +++ b/common/patches/titanium.cpp @@ -1070,7 +1070,7 @@ namespace Titanium ENCODE(OP_ReadBook) { - // no apparent slot translation needed -U + // no apparent slot translation needed EQApplicationPacket *in = *p; *p = nullptr; @@ -1949,7 +1949,7 @@ namespace Titanium DECODE(OP_ReadBook) { - // no apparent slot translation needed -U + // no apparent slot translation needed DECODE_LENGTH_ATLEAST(structs::BookRequest_Struct); SETUP_DIRECT_DECODE(BookRequest_Struct, structs::BookRequest_Struct); diff --git a/common/patches/titanium_structs.h b/common/patches/titanium_structs.h index 60b764dfe..1c3afd90b 100644 --- a/common/patches/titanium_structs.h +++ b/common/patches/titanium_structs.h @@ -2010,7 +2010,7 @@ struct BookRequest_Struct { ** */ struct Object_Struct { -/*00*/ uint32 linked_list_addr[2];// They are, get this, prev and next, ala linked list +/*00*/ uint32 linked_list_addr[2];// They are, get this, prev and next, ala linked list /*08*/ uint16 unknown008[2]; // /*12*/ uint32 drop_id; // Unique object id for zone /*16*/ uint16 zone_id; // Redudant, but: Zone the object appears in @@ -2029,8 +2029,8 @@ struct Object_Struct { /*88*/ uint32 spawn_id; // Spawn Id of client interacting with object /*92*/ }; -// 01 = generic drop, 02 = armor, 19 = weapon -//[13:40] and 0xff seems to be indicative of the tradeskill/openable items that end up returning the old style item type in the OP_OpenObject +//01 = generic drop, 02 = armor, 19 = weapon +//[13:40] and 0xff seems to be indicative of the tradeskill/openable items that end up returning the old style item type in the OP_OpenObject /* ** Click Object Struct diff --git a/common/patches/uf_structs.h b/common/patches/uf_structs.h index 2f5aa95b3..d7b14b385 100644 --- a/common/patches/uf_structs.h +++ b/common/patches/uf_structs.h @@ -2440,7 +2440,7 @@ struct BookRequest_Struct { ** */ struct Object_Struct { -/*00*/ uint32 linked_list_addr[2];// They are, get this, prev and next, ala linked list +/*00*/ uint32 linked_list_addr[2];// They are, get this, prev and next, ala linked list /*08*/ uint32 unknown008; // Something related to the linked list? /*12*/ uint32 drop_id; // Unique object id for zone /*16*/ uint16 zone_id; // Redudant, but: Zone the object appears in @@ -2460,8 +2460,8 @@ struct Object_Struct { /*100*/ uint32 spawn_id; // Spawn Id of client interacting with object /*104*/ }; -// 01 = generic drop, 02 = armor, 19 = weapon -//[13:40] and 0xff seems to be indicative of the tradeskill/openable items that end up returning the old style item type in the OP_OpenObject +//01 = generic drop, 02 = armor, 19 = weapon +//[13:40] and 0xff seems to be indicative of the tradeskill/openable items that end up returning the old style item type in the OP_OpenObject /* ** Click Object Struct diff --git a/common/shareddb.cpp b/common/shareddb.cpp index 0e057812d..396bdb494 100644 --- a/common/shareddb.cpp +++ b/common/shareddb.cpp @@ -154,7 +154,7 @@ bool SharedDatabase::SaveInventory(uint32 char_id, const ItemInst* inst, int16 s // If we never save tribute slots..how are we to ever benefit from them!!? The client // object is destroyed upon zoning - including its inventory object..and if tributes // don't exist in the database, then they will never be loaded when the new client - // object is created in the new zone object... Something to consider... -U + // object is created in the new zone object... Something to consider... // // (we could add them to the 'NoRent' checks and dispose of after 30 minutes offline) diff --git a/queryserv/database.cpp b/queryserv/database.cpp index 231e100cf..ea5bdff65 100644 --- a/queryserv/database.cpp +++ b/queryserv/database.cpp @@ -306,7 +306,7 @@ void Database::LogPlayerMove(QSPlayerLogMove_Struct* QS, uint32 items) { } void Database::LogMerchantTransaction(QSMerchantLogTransaction_Struct* QS, uint32 items) { - /* Merchant transactions are from the perspective of the merchant, not the player -U */ + /* Merchant transactions are from the perspective of the merchant, not the player */ std::string query = StringFormat("INSERT INTO `qs_merchant_transaction_record` SET `time` = NOW(), " "`zone_id` = '%i', `merchant_id` = '%i', `merchant_pp` = '%i', " "`merchant_gp` = '%i', `merchant_sp` = '%i', `merchant_cp` = '%i', " diff --git a/world/client.cpp b/world/client.cpp index b6b846f31..34a404673 100644 --- a/world/client.cpp +++ b/world/client.cpp @@ -720,7 +720,7 @@ bool Client::HandleEnterWorldPacket(const EQApplicationPacket *app) { } // This can probably be moved outside and have another method return requested info (don't forget to remove the #include "../common/shareddb.h" above) - // (This is a literal translation of the original process..I don't see why it can't be changed to a single-target query over account iteration -U) + // (This is a literal translation of the original process..I don't see why it can't be changed to a single-target query over account iteration) if (!pZoning) { size_t character_limit = EQLimits::CharacterCreationLimit(eqs->GetClientVersion()); if (character_limit > EmuConstants::CHARACTER_CREATION_LIMIT) { character_limit = EmuConstants::CHARACTER_CREATION_LIMIT; } diff --git a/zone/bot.cpp b/zone/bot.cpp index 6eb90551f..1b1da0b6a 100644 --- a/zone/bot.cpp +++ b/zone/bot.cpp @@ -4132,7 +4132,7 @@ void Bot::Spawn(Client* botCharacterOwner, std::string* errorMessage) { this->SendPosition(); // there is something askew with spawn struct appearance fields... - // I re-enabled this until I can sort it out -U + // I re-enabled this until I can sort it out uint32 itemID = 0; uint8 materialFromSlot = 0xFF; for(int i = EmuConstants::EQUIPMENT_BEGIN; i <= EmuConstants::EQUIPMENT_END; ++i) { @@ -10823,7 +10823,7 @@ void Bot::ProcessBotInspectionRequest(Bot* inspectedBot, Client* client) { // Modded to display power source items (will only show up on SoF+ client inspect windows though.) // I don't think bots are currently coded to use them..but, you'll have to use '#bot inventory list' - // to see them on a Titanium client when/if they are activated. -U + // to see them on a Titanium client when/if they are activated. for(int16 L = EmuConstants::EQUIPMENT_BEGIN; L <= MainWaist; L++) { inst = inspectedBot->GetBotItem(L); diff --git a/zone/client_packet.cpp b/zone/client_packet.cpp index f93f83018..5ff205202 100644 --- a/zone/client_packet.cpp +++ b/zone/client_packet.cpp @@ -3899,7 +3899,7 @@ void Client::Handle_OP_CastSpell(const EQApplicationPacket *app) } else if (m_inv.SupportsClickCasting(castspell->inventoryslot) || (castspell->slot == POTION_BELT_SPELL_SLOT) || (castspell->slot == TARGET_RING_SPELL_SLOT)) // sanity check { - // packet field types will be reviewed as packet transistions occur -U + // packet field types will be reviewed as packet transistions occur const ItemInst* inst = m_inv[castspell->inventoryslot]; //slot values are int16, need to check packet on this field //bool cancast = true; if (inst && inst->IsType(ItemClassCommon)) diff --git a/zone/client_process.cpp b/zone/client_process.cpp index 45cc7d386..439c2c6c6 100644 --- a/zone/client_process.cpp +++ b/zone/client_process.cpp @@ -816,14 +816,14 @@ void Client::OnDisconnect(bool hard_disconnect) { // Sends the client complete inventory used in character login -// DO WE STILL NEED THE 'ITEMCOMBINED' CONDITIONAL CODE? -U +// DO WE STILL NEED THE 'ITEMCOMBINED' CONDITIONAL CODE? //#ifdef ITEMCOMBINED void Client::BulkSendInventoryItems() { int16 slot_id = 0; // LINKDEAD TRADE ITEMS - // Move trade slot items back into normal inventory..need them there now for the proceeding validity checks -U + // Move trade slot items back into normal inventory..need them there now for the proceeding validity checks for(slot_id = EmuConstants::TRADE_BEGIN; slot_id <= EmuConstants::TRADE_END; slot_id++) { ItemInst* inst = m_inv.PopItem(slot_id); if(inst) { @@ -842,7 +842,7 @@ void Client::BulkSendInventoryItems() { RemoveDuplicateLore(false); MoveSlotNotAllowed(false); - // The previous three method calls took care of moving/removing expired/illegal item placements -U + // The previous three method calls took care of moving/removing expired/illegal item placements //TODO: this function is just retarded... it re-allocates the buffer for every //new item. It should be changed to loop through once, gather the diff --git a/zone/corpse.cpp b/zone/corpse.cpp index 236128048..ca6619539 100644 --- a/zone/corpse.cpp +++ b/zone/corpse.cpp @@ -340,7 +340,7 @@ Corpse::Corpse(Client* client, int32 in_rezexp) : Mob ( database.TransactionBegin(); - // I have an untested process that avoids this snarl up when all possessions inventory is removed..but this isn't broke -U + // I have an untested process that avoids this snarl up when all possessions inventory is removed..but this isn't broke if (!removed_list.empty()) { std::stringstream ss(""); ss << "DELETE FROM inventory WHERE charid=" << client->CharacterID(); diff --git a/zone/effects.cpp b/zone/effects.cpp index 5cc024ce2..8a42b8e09 100644 --- a/zone/effects.cpp +++ b/zone/effects.cpp @@ -756,7 +756,7 @@ void EntityList::AESpell(Mob *caster, Mob *center, uint16 spell_id, bool affect_ } else { // check to stop casting beneficial ae buffs (to wit: bard songs) on enemies... // This does not check faction for beneficial AE buffs..only agro and attackable. // I've tested for spells that I can find without problem, but a faction-based - // check may still be needed. Any changes here should also reflect in BardAEPulse() -U + // check may still be needed. Any changes here should also reflect in BardAEPulse() if (caster->IsAttackAllowed(curmob, true)) continue; if (caster->CheckAggro(curmob)) diff --git a/zone/embparser.cpp b/zone/embparser.cpp index e222edfda..3bfb2e90a 100644 --- a/zone/embparser.cpp +++ b/zone/embparser.cpp @@ -863,7 +863,7 @@ void PerlembParser::GetQuestPackageName(bool &isPlayerQuest, bool &isGlobalPlaye } } else if(isItemQuest) { - // need a valid ItemInst pointer check here..unsure how to cancel this process -U + // need a valid ItemInst pointer check here..unsure how to cancel this process const Item_Struct* item = iteminst->GetItem(); package_name = "qst_item_"; package_name += itoa(item->ID); @@ -1308,7 +1308,7 @@ void PerlembParser::ExportEventVariables(std::string &package_name, QuestEventID case EVENT_SCALE_CALC: case EVENT_ITEM_ENTER_ZONE: { - // need a valid ItemInst pointer check here..unsure how to cancel this process -U + // need a valid ItemInst pointer check here..unsure how to cancel this process ExportVar(package_name.c_str(), "itemid", objid); ExportVar(package_name.c_str(), "itemname", iteminst->GetItem()->Name); break; @@ -1316,7 +1316,7 @@ void PerlembParser::ExportEventVariables(std::string &package_name, QuestEventID case EVENT_ITEM_CLICK_CAST: case EVENT_ITEM_CLICK: { - // need a valid ItemInst pointer check here..unsure how to cancel this process -U + // need a valid ItemInst pointer check here..unsure how to cancel this process ExportVar(package_name.c_str(), "itemid", objid); ExportVar(package_name.c_str(), "itemname", iteminst->GetItem()->Name); ExportVar(package_name.c_str(), "slotid", extradata); diff --git a/zone/inventory.cpp b/zone/inventory.cpp index 35053731c..00f16c2a6 100644 --- a/zone/inventory.cpp +++ b/zone/inventory.cpp @@ -1067,12 +1067,12 @@ bool MakeItemLink(char* &ret_link, const Item_Struct *item, uint32 aug0, uint32 // Currently, enabling them causes misalignments in what the client expects. I haven't looked // into it further to determine the cause..but, the function is setup to accept the parameters. // Note: some links appear with '00000' in front of the name..so, it's likely we need to send - // some additional information when certain parameters are true -U + // some additional information when certain parameters are true //switch (GetClientVersion()) { switch (0) { case EQClientRoF2: // This operator contains 14 parameter masks..but, only 13 parameter values. - // Even so, the client link appears ok... Need to figure out the discrepancy -U + // Even so, the client link appears ok... Need to figure out the discrepancy MakeAnyLenString(&ret_link, "%1X" "%05X" "%05X" "%05X" "%05X" "%05X" "%05X" "%05X" "%1X" "%1X" "%04X" "%1X" "%05X" "%08X", 0, item->ID, @@ -1793,14 +1793,14 @@ void Client::SwapItemResync(MoveItem_Struct* move_slots) { // with any luck..this won't be needed in the future // resync the 'from' and 'to' slots on an as-needed basis - // Not as effective as the full process, but less intrusive to gameplay -U + // Not as effective as the full process, but less intrusive to gameplay Log.Out(Logs::Detail, Logs::Inventory, "Inventory desyncronization. (charname: %s, source: %i, destination: %i)", GetName(), move_slots->from_slot, move_slots->to_slot); Message(15, "Inventory Desyncronization detected: Resending slot data..."); if((move_slots->from_slot >= EmuConstants::EQUIPMENT_BEGIN && move_slots->from_slot <= EmuConstants::CURSOR_BAG_END) || move_slots->from_slot == MainPowerSource) { int16 resync_slot = (Inventory::CalcSlotId(move_slots->from_slot) == INVALID_INDEX) ? move_slots->from_slot : Inventory::CalcSlotId(move_slots->from_slot); if (IsValidSlot(resync_slot) && resync_slot != INVALID_INDEX) { - // This prevents the client from crashing when closing any 'phantom' bags -U + // This prevents the client from crashing when closing any 'phantom' bags const Item_Struct* token_struct = database.GetItem(22292); // 'Copper Coin' ItemInst* token_inst = database.CreateItem(token_struct, 1); @@ -2297,7 +2297,7 @@ void Client::RemoveDuplicateLore(bool client_update) safe_delete(inst); } - // Shared Bank and Shared Bank Containers are not checked due to their allowing duplicate lore items -U + // Shared Bank and Shared Bank Containers are not checked due to their allowing duplicate lore items if (!m_inv.CursorEmpty()) { std::list local_1; @@ -2367,7 +2367,7 @@ void Client::MoveSlotNotAllowed(bool client_update) safe_delete(inst); } - // No need to check inventory, cursor, bank or shared bank since they allow max item size and containers -U + // No need to check inventory, cursor, bank or shared bank since they allow max item size and containers // Code can be added to check item size vs. container size, but it is left to attrition for now. } diff --git a/zone/trading.cpp b/zone/trading.cpp index 91d9c8a8a..0e44a91bc 100644 --- a/zone/trading.cpp +++ b/zone/trading.cpp @@ -108,7 +108,7 @@ void Trade::AddEntity(uint16 trade_slot_id, uint32 stack_size) { ItemInst* inst2 = client->GetInv().GetItem(trade_slot_id); // it looks like the original code attempted to allow stacking... - // (it just didn't handle partial stack move actions -U) + // (it just didn't handle partial stack move actions) if (stack_size > 0) { if (!inst->IsStackable() || !inst2 || !inst2->GetItem() || (inst->GetID() != inst2->GetID()) || (stack_size > inst->GetCharges())) { client->Kick(); @@ -800,7 +800,7 @@ void Client::FinishTrade(Mob* tradingWith, bool finalizer, void* event_entry, st // QS code if(RuleB(QueryServ, PlayerLogTrades) && event_entry && event_details) { // Currently provides only basic functionality. Calling method will also - // need to be modified before item returns and rewards can be logged. -U + // need to be modified before item returns and rewards can be logged. qs_audit = (QSPlayerLogHandin_Struct*)event_entry; qs_log = true; @@ -819,7 +819,7 @@ void Client::FinishTrade(Mob* tradingWith, bool finalizer, void* event_entry, st qs_audit->npc_count = 0; } - if(qs_log) { // This can be incorporated below when revisions are made -U + if(qs_log) { // This can be incorporated below when revisions are made for (int16 trade_slot = EmuConstants::TRADE_BEGIN; trade_slot <= EmuConstants::TRADE_NPC_END; ++trade_slot) { const ItemInst* trade_inst = m_inv[trade_slot];