pa/eqemu-server
2
0
Fork 0
mirror of https://github.com/EQEmu/Server.git synced 2025-12-16 13:31:29 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

[Cleanup] Use variable for c->GetTarget() instead of calling multiple times in bot_command.cpp (#3254)

Browse Source 
# Notes
- Calling multiple times is less performant than using a variable.
This commit is contained in:
Alex King 2023-04-05 10:09:19 -04:00 committed by GitHub
parent 4a0725e278
commit 2a094e8792
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 16 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

23
zone/bot_command.cpp
View File

@ -2526,9 +2526,17 @@ void bot_command_apply_poison(Client *c, const Seperator *sep)
} }
Bot *my_rogue_bot = nullptr; Bot *my_rogue_bot = nullptr;
if (c->GetTarget() && c->GetTarget()->IsBot() && c->GetTarget()->CastToBot()->GetBotOwnerCharacterID() == c->CharacterID() && c->GetTarget()->CastToBot()->GetClass() == ROGUE) { auto t = c->GetTarget();
my_rogue_bot = c->GetTarget()->CastToBot();
if (
t &&
t->IsBot() &&
t->CastToBot()->GetBotOwnerCharacterID() == c->CharacterID() &&
t->GetClass() == ROGUE
) {
my_rogue_bot = t->CastToBot();
} }
if (!my_rogue_bot) { if (!my_rogue_bot) {
c->Message(Chat::White, "You must target a rogue bot that you own to use this command!"); c->Message(Chat::White, "You must target a rogue bot that you own to use this command!");
@ -6402,13 +6410,14 @@ void bot_subcommand_bot_report(Client *c, const Seperator *sep)
std::string ab_type_arg = sep->arg[1]; std::string ab_type_arg = sep->arg[1];
if (ab_type_arg.empty()) { if (ab_type_arg.empty()) {
if (c->GetTarget()) { auto t = c->GetTarget();
if (c->GetTarget()->IsClient() && c->GetTarget()->CastToClient() == c) if (t && t->IsClient()) {
if (t->CastToClient() == c) {
ab_type_arg = "ownergroup"; ab_type_arg = "ownergroup";
else if (c->GetTarget()->IsClient() && c->GetTarget()->CastToClient() != c) } else {
ab_type_arg = "targetgroup"; ab_type_arg = "targetgroup";
} }
else { } else {
ab_type_arg = "spawned"; ab_type_arg = "spawned";
} }
} }