[Bug Fix] Ensure close of Tribute Item search (#4439)

This commit is contained in:
JJ 2024-08-03 20:25:07 -04:00 committed by GitHub
parent 2cf5bae571
commit 2937852cf9
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194

View File

@ -340,7 +340,7 @@ bool ZoneDatabase::LoadTributes() {
return false;
}
for (auto row = results.begin(); row != results.end(); ++row) {
for (auto &row = results.begin(); row != results.end(); ++row) {
uint32 id = Strings::ToUnsignedInt(row[0]);
tributeData.name = row[1];
tributeData.description = row[2];
@ -358,7 +358,7 @@ bool ZoneDatabase::LoadTributes() {
return false;
}
for (auto row = results.begin(); row != results.end(); ++row) {
for (auto &row = results.begin(); row != results.end(); ++row) {
uint32 id = Strings::ToUnsignedInt(row[0]);
if (tribute_list.count(id) != 1) {
@ -635,11 +635,11 @@ uint32 Client::LookupTributeItemID(uint32 tribute_id, uint32 tier)
if (tribute_list.contains(tribute_id)) {
auto tribute = tribute_list.find(tribute_id);
auto item_id = tribute->second.tiers[tier].tribute_item_id;
if (!item_id) {
return 0;
if (item_id) {
return item_id;
}
return item_id;
}
return 0;
}
/*