From 270248520699cab49fc8c9ea35e5748f50707116 Mon Sep 17 00:00:00 2001 From: nytmyr <53322305+nytmyr@users.noreply.github.com> Date: Mon, 6 Nov 2023 16:03:34 -0600 Subject: [PATCH] [Bots] Fix invalid races from being created (#3681) Previously this check allowed bots of invalid races to be created. If a race was neither a valid combination or a valid player race, it would pass the check and allow bots of any race to be created. **^create 1 123 0** could create a Male Innoruuk Warrior --- zone/bot_command.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/zone/bot_command.cpp b/zone/bot_command.cpp index 0ece538be..5e45ad24b 100644 --- a/zone/bot_command.cpp +++ b/zone/bot_command.cpp @@ -8884,7 +8884,7 @@ uint32 helper_bot_create(Client *bot_owner, std::string bot_name, uint8 bot_clas return bot_id; } - if (!Bot::IsValidRaceClassCombo(bot_race, bot_class) && IsPlayerRace(bot_race)) { + if (!Bot::IsValidRaceClassCombo(bot_race, bot_class)) { const std::string bot_race_name = GetRaceIDName(bot_race); const std::string bot_class_name = GetClassIDName(bot_class); const auto view_saylink = Saylink::Silent(