[Commands] Cleanup #picklock Command (#3046)

* [Commands] Cleanup #picklock Command

# Notes
- Cleanup messages and logic.

* Update picklock.cpp
This commit is contained in:
Alex King 2023-03-05 22:34:05 -05:00 committed by GitHub
parent a90d41480a
commit 218ef80f96
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23

View File

@ -2,23 +2,28 @@
void command_picklock(Client *c, const Seperator *sep) void command_picklock(Client *c, const Seperator *sep)
{ {
Mob *target = c->GetTarget(); if (!c->GetTarget() || !c->GetTarget()->IsNPC()) {
if (!target) { c->Message(Chat::White, "You must target an NPC to use this command.");
c->Message(Chat::Red, "You must have a target.");
return; return;
} }
if (target->IsNPC()) { auto t = c->GetTarget()->CastToNPC();
if (c->HasSkill(EQ::skills::SkillPickLock)) { if (c->HasSkill(EQ::skills::SkillPickLock)) {
if (DistanceSquaredNoZ(c->GetPosition(), target->GetPosition()) > RuleI(Adventure, LDoNTrapDistanceUse)) { if (DistanceSquaredNoZ(c->GetPosition(), t->GetPosition()) > RuleI(Adventure, LDoNTrapDistanceUse)) {
c->Message(Chat::Red, "%s is too far away.", target->GetCleanName()); c->Message(
Chat::White,
fmt::format(
"{} is too far away.",
c->GetTargetDescription(t)
).c_str()
);
return; return;
} }
c->HandleLDoNPickLock(target->CastToNPC(), c->GetSkill(EQ::skills::SkillPickLock), LDoNTypeMechanical);
} c->HandleLDoNPickLock(t, c->GetSkill(EQ::skills::SkillPickLock), LDoNTypeMechanical);
else { } else {
c->Message(Chat::Red, "You do not have the pick locks skill."); c->Message(Chat::White, "You do not have the Pick Lock skill.");
}
} }
} }