[Feature] Implement /changename & related script bindings. Clean up #set name (#4770)

* initial work, need to clean up gm commands still

* cleaned up command, works without kicking char select now

* remove thj-specific methods

* add script hooks

* actually clear flag

* rework questmgr::rename

* remove unnecessary logging

* revert

* added missing binding to perl api and updated some text

* don't return a value

* Fix some bad argument types.

* adjust case

* alpha order

* refactor some old string stuff

* don't quote integers, bob

---------

Co-authored-by: Zimp <zimp@zenryo.xyz>
Co-authored-by: Chris Miles <akkadius1@gmail.com>
This commit is contained in:
catapultam-habeo
2025-03-19 19:00:45 -07:00
committed by GitHub
parent be6a5d5f50
commit 213fe6a9e9
14 changed files with 223 additions and 39 deletions
+2 -3
View File
@@ -1310,15 +1310,14 @@ void QuestManager::rename(std::string name) {
QuestManagerCurrentQuestVars();
if (initiator) {
std::string current_name = initiator->GetName();
if (initiator->ChangeFirstName(name.c_str(), current_name.c_str())) {
if (initiator->ChangeFirstName(name)) {
initiator->Message(
Chat::White,
fmt::format(
"Successfully renamed to {}, kicking to character select.",
"Successfully renamed to {}.",
name
).c_str()
);
initiator->Kick("Name was changed.");
} else {
initiator->Message(
Chat::Red,