[Loginserver] Modernize codebase (#4647)

* Beginning of cleanup

* More cleanup

* More cleanup

* Enc cleanup

* client manager cleanup

* client cleanup

* More cleanup

* More cleanup

* Cleanup

* More cleanup, account  context, account management

* Remove positional fmt bindings

* Use LoginAccountContext

* Update loginserver_webserver.cpp

* Remove comments

* Port CreateLoginServerAccount to repositories

* More cleanup

* More cleanup

* More cleanup

* More cleanup

* Remove a ton of functions

* More cleanup

* More cleanup

* More cleanup

* Cleanup SendClientAuthToWorld

* Consolidate world server logic

* Update login_accounts_repository.h

* Update login_accounts_repository.h

* Move api tokens to repositories

* Cleanup options

* Move everything else to repositories

* Update account_management.cpp

* uint64 account

* Update login_schema.sql

* Fix

* Update world_server.cpp

* auto

loginserver/client_manager.h

@@ -7,56 +7,23 @@
 #include "client.h"
 #include <list>
 
-/**
-* Client manager class, holds all the client objects and does basic processing.
-*/
 class ClientManager {
 public:
-	/**
-	 * Constructor: sets up the stream factories and opcode managers
-	 */
 	ClientManager();
-
-	/**
-	 * Destructor: shuts down the streams and opcode managers
-	 */
 	~ClientManager();
-
-	/**
-	 * Processes every client in the internal list, removes them if necessary.
-	 */
 	void Process();
-
-	/**
-	 * Removes a client with a certain account id
-	 *
-	 * @param account_id
-	 * @param loginserver
-	 */
-	void RemoveExistingClient(unsigned int account_id, const std::string &loginserver);
-
-	/**
-	 * Gets a client (if exists) by their account id
-	 *
-	 * @param account_id
-	 * @param loginserver
-	 * @return
-	 */
-	Client *GetClient(unsigned int account_id, const std::string &loginserver);
+	void RemoveExistingClient(unsigned int c, const std::string &loginserver);
+	Client *GetClient(unsigned int c, const std::string &loginserver);
 private:
-
-	/**
-	 * Processes disconnected clients, removes them if necessary
-	 */
 	void ProcessDisconnect();
 
-	std::list<Client *>      clients;
-	OpcodeManager            *titanium_ops;
-	EQ::Net::EQStreamManager *titanium_stream;
-	OpcodeManager            *sod_ops;
-	EQ::Net::EQStreamManager *sod_stream;
-	OpcodeManager            *larion_ops;
-	EQ::Net::EQStreamManager* larion_stream;
+	std::list<Client *>      m_clients;
+	OpcodeManager            *m_titanium_ops;
+	EQ::Net::EQStreamManager *m_titanium_stream;
+	OpcodeManager            *m_sod_ops;
+	EQ::Net::EQStreamManager *m_sod_stream;
+	OpcodeManager            *m_larion_ops;
+	EQ::Net::EQStreamManager *m_larion_stream;
 };
 
 #endif