pa/eqemu-server
2
0
Fork 0
mirror of https://github.com/EQEmu/Server.git synced 2025-12-23 20:31:28 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

[Cleanup] Remove always true condition in Strings::Commify() (#3193)

Browse Source 
# Notes
- `i < 0` was always true.
This commit is contained in:
Alex King 2023-04-05 11:23:24 -04:00 committed by GitHub
parent fef2f9fc61
commit 1499f3338e
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 2 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
common/strings.cpp
View File

@ -287,15 +287,12 @@ std::string Strings::Commify(const std::string &number)
for (i = string_length - 3; i >= 0; i -= 3) { for (i = string_length - 3; i >= 0; i -= 3) {
if (i > 0) { if (i > 0) {
temp_string = "," + number.substr(static_cast<unsigned long>(i), 3) + temp_string; temp_string = "," + number.substr(static_cast<unsigned long>(i), 3) + temp_string;
} } else {
else {
temp_string = number.substr(static_cast<unsigned long>(i), 3) + temp_string; temp_string = number.substr(static_cast<unsigned long>(i), 3) + temp_string;
} }
} }
if (i < 0) {
temp_string = number.substr(0, static_cast<unsigned long>(3 + i)) + temp_string; temp_string = number.substr(0, static_cast<unsigned long>(3 + i)) + temp_string;
}
return temp_string; return temp_string;
} }