pa/eqemu-server
2
0
Fork 0
mirror of https://github.com/EQEmu/Server.git synced 2025-12-13 14:41:28 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

[Hotfix] Fix potential race for crash dumps (Linux)

Browse Source
This commit is contained in:
Akkadius 2022-07-31 04:10:09 -05:00
parent 3cccb183a2
commit 0dfc6eaa15
1 changed files with 23 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

27
common/crash.cpp
View File

@ -2,9 +2,24 @@
#include "eqemu_logsys.h" #include "eqemu_logsys.h"
#include "crash.h" #include "crash.h"
inline std::string random_string(size_t length)
{
auto randchar = []() -> char {
const char charset[] = "0123456789"
"ABCDEFGHIJKLMNOPQRSTUVWXYZ"
"abcdefghijklmnopqrstuvwxyz";
const size_t max_index = (sizeof(charset) - 1);
return charset[static_cast<size_t>(std::rand()) % max_index];
};
std::string str(length, 0);
std::generate_n(str.begin(), length, randchar);
return str;
}
std::string execute(const std::string &cmd, bool return_result = true) std::string execute(const std::string &cmd, bool return_result = true)
{ {
const char *file_name = "exec-result"; std::string random = "/tmp/" + random_string(25);
const char *file_name = random.c_str();
if (return_result) { if (return_result) {
#ifdef _WINDOWS #ifdef _WINDOWS
@ -154,18 +169,22 @@ void print_trace()
{ {
bool does_gdb_exist = execute("gdb -v").find("GNU") != std::string::npos; bool does_gdb_exist = execute("gdb -v").find("GNU") != std::string::npos;
if (!does_gdb_exist) { if (!does_gdb_exist) {
LogCrash("[Error] GDB is not installed, if you want crash dumps on Linux to work properly you will need GDB installed"); LogCrash(
"[Error] GDB is not installed, if you want crash dumps on Linux to work properly you will need GDB installed"
);
std::exit(1); std::exit(1);
} }
auto uid = geteuid(); auto uid = geteuid();
std::string temp_output_file = "/tmp/dump-output"; std::string temp_output_file = "/tmp/dump-output";
// check for passwordless sudo if not root // check for passwordless sudo if not root
if (uid != 0) { if (uid != 0) {
bool has_passwordless_sudo = execute("sudo -n true").find("a password is required") == std::string::npos; bool has_passwordless_sudo = execute("sudo -n true").find("a password is required") == std::string::npos;
if (!has_passwordless_sudo) { if (!has_passwordless_sudo) {
LogCrash("[Error] Current user does not have passwordless sudo installed. It is required to automatically process crash dumps with GDB as non-root."); LogCrash(
"[Error] Current user does not have passwordless sudo installed. It is required to automatically process crash dumps with GDB as non-root."
);
std::exit(1); std::exit(1);
} }
} }