Reduce GetCorrectBotSpellType branching slightly

This is still an ugly ass function but my brain is melted
This commit is contained in:
nytmyr
2025-01-24 13:09:39 -06:00
parent f50b64cb11
commit 06dcd62d8c
+5 -5
View File
@@ -644,8 +644,10 @@ uint16 GetCorrectBotSpellType(uint16 spell_type, uint16 spell_id) {
else if (IsRegularGroupHealSpell(spell_id)) { else if (IsRegularGroupHealSpell(spell_id)) {
correct_type = BotSpellTypes::GroupHeals; correct_type = BotSpellTypes::GroupHeals;
} }
return correct_type;
} }
else {
if (IsVeryFastHealSpell(spell_id)) { if (IsVeryFastHealSpell(spell_id)) {
correct_type = BotSpellTypes::VeryFastHeals; correct_type = BotSpellTypes::VeryFastHeals;
} }
@@ -665,17 +667,15 @@ uint16 GetCorrectBotSpellType(uint16 spell_type, uint16 spell_id) {
correct_type = BotSpellTypes::RegularHeal; correct_type = BotSpellTypes::RegularHeal;
} }
} }
}
else if (IsAnyBuffSpell(spell_id)) { else if (IsAnyBuffSpell(spell_id)) {
correct_type = BotSpellTypes::Buff;
if (IsResistanceOnlySpell(spell_id)) { if (IsResistanceOnlySpell(spell_id)) {
correct_type = BotSpellTypes::ResistBuffs; correct_type = BotSpellTypes::ResistBuffs;
} }
else if (IsDamageShieldOnlySpell(spell_id)) { else if (IsDamageShieldOnlySpell(spell_id)) {
correct_type = BotSpellTypes::DamageShields; correct_type = BotSpellTypes::DamageShields;
} }
else {
correct_type = BotSpellTypes::Buff;
}
} }
} }